This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
truncate commit message in commit view if necessary #59913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdencheek
reviewed
Feb 2, 2024
| @@ -353,7 +371,6 @@ export const GitCommitNode: React.FunctionComponent<React.PropsWithChildren<GitC | |||
| {!extraCompact && <Link to={canonicalURL}>{oidElement}</Link>} | |||
| {afterElement} | |||
| </div> | |||
| {commitMessageBody} | |||
There was a problem hiding this comment.
I'm surprised to see this line deleted. Doesn't this just make it impossible to actually show the commit message body?
camdencheek
reviewed
Feb 2, 2024
Comment on lines
+174
to
+181
| <Button | ||
| variant="link" | ||
| size="sm" | ||
| display="inline" | ||
| onClick={() => setTruncateCommitMessage(!truncateCommitMessage)} | ||
| > | ||
| {truncateCommitMessage ? 'see more' : 'see less'} | ||
| </Button> |
There was a problem hiding this comment.
We also use the commitMessageBody to render the byline below. I do not think we ever want an expand/collapse button in the byline
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we showed the full commit message on the commit view. Now, we give the user the option to see more, or less of the commit message.
Test plan
Manual testing/passing CI/CD