Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove Iterator.Domain #46

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

AndrewSisley
Copy link
Collaborator

Relevant issue(s)

Resolves #42

Description

Removes the Iterator.Domain function.

As discussed in #40 - as the implementing behaviour varied quite a bit and it didn't fully make sense.

@AndrewSisley AndrewSisley added this to the CoreKV v0.1 milestone Jan 30, 2025
@AndrewSisley AndrewSisley requested a review from a team January 30, 2025 00:46
@AndrewSisley AndrewSisley self-assigned this Jan 30, 2025
Copy link

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley merged commit cf3a95a into sourcenetwork:main Jan 30, 2025
5 checks passed
@AndrewSisley AndrewSisley deleted the 42-rm-domain branch January 30, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Iterator.Domain function
2 participants