fix: Return exact prefix match from memory iterator #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, this should have been removed in an earlier PR and I missed it.
AndrewSisley
commented
Jan 30, 2025
| @@ -22,9 +22,6 @@ type iterator struct { | |||
| // The key at which this iterator ends, inclusive. | |||
| end []byte | |||
|
|
|||
| // If this is true, `start` is inclusive, else `start` is exclusive. | |||
| isStartInclusive bool | |||
There was a problem hiding this comment.
@fredcarle Sorry as I pushed back on doing this in an earlier PR as I thought this would be more involved than this and require cleanup in badger, however the badger code that I thought was trying to do this was trying to do something else instead and this change was fairly easy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #27
Description
Returns exact prefix match from memory iterator, matching the badger behaviour.
Also removes some dead code I accidentally left in from a previous PR.