Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i): Add dep kubo v0.25.0 for ipfs v0.16.0 #2158

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Dec 27, 2023

Relevant issue(s)

Resolves #2157

Description

  • Fix broken mod tidy, by adding the Kubo(v0.25.0) dependency for IPFS(v0.16.0), because it was removed after v0.15.0.

More detail: ipfs/boxo#522

@shahzadlone shahzadlone added ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies deprecate Indicates something is deprecated. labels Dec 27, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.9 milestone Dec 27, 2023
@shahzadlone shahzadlone requested a review from a team December 27, 2023 17:33
@shahzadlone shahzadlone self-assigned this Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31a4643) 74.33% compared to head (5456aaf) 74.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2158      +/-   ##
===========================================
- Coverage    74.33%   74.33%   -0.01%     
===========================================
  Files          252      252              
  Lines        25217    25217              
===========================================
- Hits         18745    18743       -2     
- Misses        5189     5191       +2     
  Partials      1283     1283              
Flag Coverage Δ
all-tests 74.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a4643...5456aaf. Read the comment docs.

@shahzadlone shahzadlone merged commit 41581a4 into sourcenetwork:develop Dec 27, 2023
31 checks passed
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Jan 22, 2024
## Relevant issue(s)
Resolves sourcenetwork#2157

## Description
- Fix broken mod tidy, by adding the Kubo(v0.25.0) dependency for
IPFS(v0.16.0), because it was removed after v0.15.0.

More detail: ipfs/boxo#522
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
## Relevant issue(s)
Resolves sourcenetwork#2157

## Description
- Fix broken mod tidy, by adding the Kubo(v0.25.0) dependency for
IPFS(v0.16.0), because it was removed after v0.15.0.

More detail: ipfs/boxo#522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build This is issue is about the build or CI system, and the administration of it. dependencies Related to dependencies deprecate Indicates something is deprecated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken mod tidy due to Kubo(v0.25.0) removed from IPFS(v0.16.0)
2 participants