Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add contraints and embedding directives #3405

Merged
merged 34 commits into from
Feb 7, 2025

add schemas with embedding tests outside of patch.

58ca89e
Select commit
Loading
Failed to load commit list.
Merged

feat: Add contraints and embedding directives #3405

add schemas with embedding tests outside of patch.
58ca89e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2025 in 0s

78.60% (+0.26%) compared to 34eab3f

View this Pull Request on Codecov

78.60% (+0.26%) compared to 34eab3f

Details

Codecov Report

Attention: Patch coverage is 83.48624% with 216 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (34eab3f) to head (58ca89e).

Files with missing lines Patch % Lines
client/normal_new.go 55.45% 45 Missing ⚠️
internal/db/embedding.go 66.29% 24 Missing and 6 partials ⚠️
internal/planner/sum.go 36.84% 24 Missing ⚠️
client/document.go 69.01% 17 Missing and 5 partials ⚠️
internal/core/encoding.go 47.62% 20 Missing and 2 partials ⚠️
internal/request/graphql/schema/collection.go 81.82% 10 Missing and 4 partials ⚠️
internal/encoding/float.go 84.52% 10 Missing and 3 partials ⚠️
client/schema_field_description.go 62.07% 11 Missing ⚠️
internal/db/errors.go 0.00% 8 Missing ⚠️
internal/db/fetcher/indexer_matchers.go 58.82% 7 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3405      +/-   ##
===========================================
+ Coverage    78.34%   78.60%   +0.26%     
===========================================
  Files          395      396       +1     
  Lines        36286    37333    +1047     
===========================================
+ Hits         28426    29342     +916     
- Misses        6194     6315     +121     
- Partials      1666     1676      +10
Files with missing lines Coverage Δ
client/collection_description.go 81.93% <100.00%> (+1.66%) ⬆️
client/collection_field_description.go 71.43% <100.00%> (+1.43%) ⬆️
client/ctype.go 93.55% <100.00%> (ø)
client/definitions.go 75.88% <100.00%> (+0.24%) ⬆️
client/errors.go 67.05% <100.00%> (+6.23%) ⬆️
client/normal_array.go 98.11% <100.00%> (+0.11%) ⬆️
client/normal_array_of_nillables.go 97.03% <100.00%> (+0.19%) ⬆️
client/normal_nil.go 95.12% <100.00%> (+0.84%) ⬆️
client/normal_nillable_array.go 98.80% <100.00%> (+0.09%) ⬆️
client/normal_nillable_array_of_nillables.go 100.00% <100.00%> (ø)
... and 34 more

... and 16 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eab3f...58ca89e. Read the comment docs.

View more details on Codecov