-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Decouple staking logic from the tier module #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e corresponding tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #11 +/- ##
==========================================
+ Coverage 28.53% 28.67% +0.14%
==========================================
Files 148 148
Lines 6225 6131 -94
==========================================
- Hits 1776 1758 -18
+ Misses 4336 4269 -67
+ Partials 113 104 -9 ☔ View full report in Codecov by Sentry. |
…llCredits package-private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR streamlines the Tier module by removing all interactions with the staking keeper (e.g.,
Delegate
,Undelegate
,BeginRedelegation
, etc.) and introduces several fixes and improvements.Tasks
Lock
,Unlock
,Redelegate
, andCancelUnlocking
.unbondTime
and only rely onunlockTime
to complete the unlocking.SubtractUnlockingLockup
.unlockTime
andcompletionTime
to benil
instead oftime.Time{}
to reduce ambiguity.creation_height
toMsgUnlockResponse
.proratedCredit
, addTestCalculateProratedCredit
andTestProratedCredit
.TestBurnAllCredits
andTestResetAllCredits
.