Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update acp_core submodule and integrate latest changes #14

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

iverc
Copy link
Contributor

@iverc iverc commented Jan 21, 2025

This PR updates the acp_core submodule and introduces numerous fixes and refactoring required to integrate with the latest acp_core changes.

@iverc iverc self-assigned this Jan 21, 2025
@iverc iverc requested review from Lodek and jsimnz January 21, 2025 01:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 54.71698% with 24 lines in your changes missing coverage. Please review.

Project coverage is 28.76%. Comparing base (77ef72e) to head (b189b07).

Files with missing lines Patch % Lines
x/acp/client/cli/policy_cmd.go 0.00% 7 Missing ⚠️
tests/integration/acp/utils.go 80.00% 4 Missing and 2 partials ⚠️
tests/integration/acp/dispatchers.go 42.85% 4 Missing ⚠️
x/acp/types/policy_cmd.go 0.00% 3 Missing ⚠️
x/acp/signed_policy_cmd/builder.go 0.00% 2 Missing ⚠️
x/acp/client/cli/tx_bearer_policy_cmd.go 0.00% 1 Missing ⚠️
x/acp/client/cli/tx_direct_policy_cmd.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #14      +/-   ##
==========================================
+ Coverage   28.53%   28.76%   +0.23%     
==========================================
  Files         148      148              
  Lines        6225     6254      +29     
==========================================
+ Hits         1776     1799      +23     
- Misses       4336     4340       +4     
- Partials      113      115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants