Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General fixes #6

Merged
merged 8 commits into from
Nov 23, 2024
Merged

fix: General fixes #6

merged 8 commits into from
Nov 23, 2024

Conversation

iverc
Copy link
Contributor

@iverc iverc commented Nov 22, 2024

Description

This PR aims to address multiple issues and clean up the codebase a bit.

Tasks

  • Fix panic due to missing IBC params when exporting genesis
  • Refactor SetConfig to be reused across multiple files
  • Fix failing workflow due to the recent Dockerfile change
  • Minor fixes and cleanup

@iverc iverc requested a review from jsimnz November 22, 2024 00:54
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! config changes are nice.

For the IBC param stuff, what was the problem here? You noted set default IBC params until app wiring is fully supported, can you add some context here?

@iverc
Copy link
Contributor Author

iverc commented Nov 23, 2024

LGTM! config changes are nice.

For the IBC param stuff, what was the problem here? You noted set default IBC params until app wiring is fully supported, can you add some context here?

We are currently registering IBC modules manually in app/ibc.go, and the default params were not set, causing a panic on ExportGenesis.

@iverc iverc merged commit e7bd275 into dev Nov 23, 2024
1 check passed
@iverc iverc deleted the iverc/general-fixes branch December 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants