Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update deploy_build_artifact.yaml permissions and artifact path #1

Open
wants to merge 1 commit into
base: base-sha/811be262142b167fe851acf8ce0c64c65153c4c2
Choose a base branch
from

Conversation

sourcery-ai-experiments-bot
Copy link
Collaborator

@sourcery-ai-experiments-bot sourcery-ai-experiments-bot commented Jul 24, 2024

Summary by Sourcery

This pull request updates the deploy_build_artifact.yaml workflow by adding a 'workflow_dispatch' trigger, adjusting the artifact path in the 'upload-artifact' step, and modifying the 'publish release' step to include the bundle path in the artifacts.

  • CI:
    • Added 'workflow_dispatch' trigger to the deploy_build_artifact.yaml workflow.
  • Deployment:
    • Updated artifact path in the 'upload-artifact' step to only include 'dist/*'.
    • Modified 'publish release' step to include the bundle path in the artifacts.

@sourcery-ai-experiments-bot
Copy link
Collaborator Author

This is a benchmark review for experiment review_of_reviews_20240724.
Run ID: review_of_reviews_20240724/benchmark_2024-07-24T00-19-03_v1-21-0-35-g39686f12d.

This pull request was cloned from https://github.com/mnbf9rca/pydantic_tfl_api/pull/57. (Note: the URL is not a link to avoid triggering a notification on the original pull request.)

Experiment configuration
review_config:
  # User configuration for the review
  # - benchmark - use the user config from the benchmark reviews
  # - <value> - use the value directly
  user_review_config:
    enable_ai_review: true
    enable_rule_comments: false

    enable_complexity_comments: benchmark
    enable_security_comments: benchmark
    enable_tests_comments: benchmark
    enable_comment_suggestions: benchmark
    enable_functionality_review: benchmark

    enable_pull_request_summary: benchmark
    enable_review_guide: benchmark

    enable_approvals: true

  ai_review_config:
    # The model responses to use for the experiment
    # - benchmark - use the model responses from the benchmark reviews
    # - llm - call the language model to generate responses
    model_responses:
      comments_model: benchmark
      comment_area_model: benchmark
      comment_validation_model: benchmark
      comment_suggestion_model: benchmark
      complexity_model: benchmark
      docstrings_model: benchmark
      functionality_model: benchmark
      security_model: benchmark
      tests_model: benchmark
      pull_request_summary_model: benchmark
      review_guide_model: benchmark

# The pull request dataset to run the experiment on
pull_request_dataset:
- https://github.com/kloudlite/web/pull/255
- https://github.com/kloudlite/helm-charts/pull/111
- https://github.com/womboai/edge-optimization-subnet/pull/2
- https://github.com/gdsfactory/gdsfactory/pull/3016
- https://github.com/gdsfactory/gplugins/pull/447
- https://github.com/gdsfactory/gdsfactory/pull/3017
- https://github.com/gdsfactory/kfactory/pull/435
- https://github.com/gdsfactory/kfactory/pull/436
- https://github.com/gdsfactory/gdsfactory/pull/3018
- https://github.com/gdsfactory/gdsfactory/pull/3020
- https://github.com/emoss08/Trenova/pull/275
- https://github.com/open-data/oc_search/pull/34
- https://github.com/albumentations-team/albumentations/pull/1854
- https://github.com/TeamKillerX/RyuzakiLib/pull/53
- https://github.com/nikhilbadyal/docker-py-revanced/pull/540
- https://github.com/Jaycelab/Jaycelab/pull/2
- https://github.com/Awesome-RJ/Skynet-System/pull/4
- https://github.com/hbmartin/overcast-to-sqlite/pull/28
- https://github.com/electionscience/vote.electionscience.org/pull/207
- https://github.com/electionscience/vote.electionscience.org/pull/208
- https://github.com/electionscience/vote.electionscience.org/pull/209
- https://github.com/szw0407/Bypass-SDU-Unified-Identity-Authentication-Platform-Device-Chesk/pull/1
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/55
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/56
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/57
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/58
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/59
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/61
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/62
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/63
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/64
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/67
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/68
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/69
- https://github.com/mnbf9rca/pydantic_tfl_api/pull/60
- https://github.com/ToolDelta/PluginMarket/pull/9
- https://github.com/duyet/clickhouse-monitoring/pull/313
- https://github.com/duyet/clickhouse-monitoring/pull/315
- https://github.com/duyet/clickhouse-monitoring/pull/314
- https://github.com/hasansezertasan/openapipages/pull/27
- https://github.com/dan5e3s6ares/a-real-mock-api/pull/7
- https://github.com/4DNucleome/PartSeg/pull/1165
- https://github.com/4DNucleome/PartSeg/pull/1166
- https://github.com/4DNucleome/PartSeg/pull/1167
- https://github.com/4DNucleome/PartSeg/pull/1168
- https://github.com/EspenAlbert/atlas-init/pull/17
- https://github.com/jschalk/jaar/pull/278
- https://github.com/jschalk/jaar/pull/279
- https://github.com/jschalk/jaar/pull/280
- https://github.com/bitcashorg/smartsale/pull/282
review_comment_labels:
- label: correct
  question: Is this comment correct?
- label: helpful
  question: Is this comment helpful?
- label: comment-type
  question: Is the comment type correct?
- label: comment-area
  question: Is the comment area correct?
- label: llm-test
  question: |
    What type of LLM test could this comment become?
    - 👍 - this comment is really good/important and we should always make it
    - 👎 - this comment is really bad and we should never make it
    - no reaction - don't turn this comment into an LLM test

# Benchmark reviews generated by running
#   python -m scripts.experiment benchmark <experiment_name>
benchmark_reviews: []

@SourceryAI
Copy link

SourceryAI commented Jul 24, 2024

Reviewer's Guide by Sourcery

This pull request updates the 'deploy_build_artifact.yaml' workflow by modifying the artifact paths for the 'upload-artifact' and 'publish release' steps, and adds a 'workflow_dispatch' trigger. The changes ensure that the 'upload-artifact' step only includes 'dist/' and the 'publish release' step includes both 'dist/' and the bundle path from 'attest-artifacts' outputs.

File-Level Changes

Files Changes
.github/workflows/deploy_build_artifact.yaml Updated artifact paths and added a manual trigger to the 'deploy_build_artifact.yaml' workflow.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@SourceryAI SourceryAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sourcery-ai-experiments-bot - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Ensure that the new artifact paths and 'workflow_dispatch' trigger are thoroughly tested to verify correct functionality.
  • Consider adding comments or documentation within the YAML file to explain the purpose of these changes for future maintainers.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

LangSmith trace

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants