-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sorts group mappings in ldap.toml by org_role #467
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR @v0nNemizez! Looks good in principal but it appears to have broken indempotency as the resource is converging on the second run, looks like |
what do you mean here? Im running this on a company test server running against the company AD with nested groups, and this works as intended and sovled our problems:) |
If you look at the CI tests then you'll see that all the LDAP ones have failed as Kitchen has failed as the run shouldn't converge a second time but it has due to the https://github.com/sous-chefs/grafana/actions/runs/11340425253/job/31536848255?pr=467#step:4:2309 It may work but unfortunately it isn't right :) |
Description
Due to the way Grafana reads group mappings, the mappings needs to be sorted so it reads them in this order: Admin->Editor -> Viewer.
Check List
## Unreleased