Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecated warning for Kernel#Namespace() #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhiroe
Copy link
Contributor

@rhiroe rhiroe commented Jan 10, 2025

Receive a deprecation warning for Kernel#Namespace() in RBS 3.8 or later.

$ bundle exec rbs --version
rbs 3.8.1

$ bundle exec rake test
Kernel#Namespace() is deprecated. Use RBS::Namespace.parse instead.

Use RBS::Namespace.parse instead of Kernel#Namespace().

I have verified that the test passes on RBS 3.5, 3.6, 3.7, and 3.8.

@rhiroe rhiroe marked this pull request as ready for review January 10, 2025 12:58
@tk0miya
Copy link
Contributor

tk0miya commented Jan 10, 2025

+1 for Namespace.

On the other hand, we need to update the dependency to use RBS::TypeName.parse because it was added since v3.8.0.
ruby/rbs#2123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants