feat!: extend MsmHandle to interoperate more easily with affine elements (PROOF-831) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
changed the title
rnburn
changed the title
JayWhite2357
previously approved these changes
May 29, 2024
src/compute/curve.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl<C: SwCurveConfig> Curve for ElementP2<C> { |
There was a problem hiding this comment.
Doing this would remove the need for the new SwCurveConfig trait and would let you impl Curve for ark_bls12_381::g1::Config. It's not really a Curve, but you could rename the trait to CurveId if you don't like the Curve name at that point.
Suggested change
| impl<C: SwCurveConfig> Curve for ElementP2<C> { | |
| impl<C: ark_ec::short_weierstrass::SWCurveConfig + Curve> Curve for ElementP2<C> { |
There was a problem hiding this comment.
I changed to an associated constant. I kept SwCurveConfig since it's used to constrain the extension trait SwMsmHandle.
There was a problem hiding this comment.
You could do this to get around that:
impl<C: ark_ec::short_weierstrass::SWCurveConfig + CurveId + Clone> SwMsmHandle for MsmHandle<ElementP2<C>>
rnburn
changed the title
JayWhite2357
approved these changes
May 29, 2024
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Make it more easy to work with elements in affine form using MsmHandle.
What changes are included in this PR?
Add the trait SwMsmHandle to extent MsmHandle with methods for affine points.
Are these changes tested?
Yes