Failing tests

spacecowboy · Feb 21, 2024 · 314ae4f · 314ae4f
1 parent 0d4aa38
commit 314ae4f
Show file tree

Hide file tree

Showing 6 changed files with 215 additions and 172 deletions.
diff --git a/app/src/androidTest/java/com/nononsenseapps/feeder/GofeedTest.kt b/app/src/androidTest/java/com/nononsenseapps/feeder/GofeedTest.kt
@@ -35,7 +35,7 @@ class GofeedTest {
     @Test
     fun testParse() {
         val j =
-            feedergofeed.Feedergofeed.parseBody(
+            feedergofeed.Feedergofeed.parseBodyString(
                 """
                 <rss version="2.0">
                     <channel>

diff --git a/app/src/androidTest/java/com/nononsenseapps/feeder/model/FeedParserTest.kt b/app/src/androidTest/java/com/nononsenseapps/feeder/model/FeedParserTest.kt
@@ -4,6 +4,7 @@ package com.nononsenseapps.feeder.model
 
 import com.nononsenseapps.feeder.di.networkModule
 import com.nononsenseapps.feeder.model.gofeed.Experiment
+import com.nononsenseapps.feeder.util.getOrElse
 import com.nononsenseapps.jsonfeed.cachingHttpClient
 import kotlinx.coroutines.runBlocking
 import okhttp3.MediaType.Companion.toMediaTypeOrNull
@@ -65,20 +66,23 @@ class FeedParserTest : DIAware {
     fun canParseUkrnet() {
         runBlocking {
             readResource("rss_ukrnet.xml") {
-                val feed = exp.parseBody(it)
+//                val feed = exp.parseBody(it)
 //
-//                val feed =
-//                    feedParser.parseFeedResponse(
-//                        URL("https://suspilne.media/rss/ukrnet.rss"),
-//                        it,
-//                        null,
-//                    )
-
-//                feed.leftOrNull()?.throwable?.let { t ->
-//                    throw t
-//                }
-
-                assertEquals(20, feed?.items?.size, "Expected 20 items")
+
+//                assertEquals(20, feed?.items?.size, "Expected 20 items")
+
+                val feed =
+                    feedParser.parseFeedResponse(
+                        URL("https://suspilne.media/rss/ukrnet.rss"),
+                        it,
+                        null,
+                    )
+
+                feed.leftOrNull()?.throwable?.let { t ->
+                    throw t
+                }
+
+                assertEquals(20, feed.getOrNull()?.items?.size, "Expected 20 items")
             }
         }
     }
@@ -725,7 +729,11 @@ class FeedParserTest : DIAware {
     @Throws(Exception::class)
     fun londoner() =
         runBlocking {
-            val feed = londoner.use { feedParser.parseFeedResponse(it) }.getOrNull()!!
+            val feed =
+                londoner.use { feedParser.parseFeedResponse(it) }.getOrElse {
+                    System.err.println(it)
+                    throw it.throwable!!
+                }
 
             assertEquals("http://londonist.com/", feed.home_page_url)
             assertEquals("http://londonist.com/feed", feed.feed_url)