-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update postcli for compatibility with multismeshing #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #270 +/- ##
=======================================
Coverage 74.3% 74.3%
=======================================
Files 29 29
Lines 1539 1543 +4
=======================================
+ Hits 1144 1147 +3
- Misses 254 258 +4
+ Partials 141 138 -3 ☔ View full report in Codecov by Sentry. |
4 tasks
poszu
reviewed
Feb 27, 2024
poszu
approved these changes
Feb 27, 2024
This was referenced Feb 27, 2024
spacemesh-bors bot
pushed a commit
to spacemeshos/go-spacemesh
that referenced
this pull request
Mar 4, 2024
…tities (#5592) ## Motivation This completes the implementation of multi-smeshing support. Related: spacemeshos/post#270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of spacemeshos/go-spacemesh#5089
Closes #219
This updates
postcli
with the changes for multi-smeshing setup.postcli
now stores a generated key inidentity.key
instead ofkey.bin
and informs the user that they have to copy the file to thedatadir
of the nodeidentities.key
is checked to be compatible with theNodeID
in thepostdata_metadata.json
file (only if both files are present-id
is checked against both theidentities.key
file andNodeID
inpostdata_metadata.json
and user has to confirm a warning that providing a mismatched value potentially corrupts their data.-numUnits
has to be set ifpostdata_metadata.json
cannot be found. Ifpostdata_metadata.json
is present the value will be read from there. If the provided value does not match the value in thepostdata_metadata.json
file the user has to confirm that they want to continue and is informed that providing a lower value will delete data.-commitmentAtxId
has to be set ifpostdata_metadata.json
cannot be found. Ifpostdata_metadata.json
is present the value will be read from there. If the provided value does not match the value in thepostdata_metadata.json
file the user has to confirm that they want to continue and is informed that providing a wrong value can corrupt their data.provider
has to be setlabelsPerUnit
andscryptN
trigger a warning if set and do not match mainnet values. User has to confirm that this will generate data that is not compatible with mainnet.log.Print
andlog.Fatal
instead offmt.Println