Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tutorial: zlib -> gmake #269

Merged
merged 1 commit into from
Oct 31, 2023
Merged

tutorial: zlib -> gmake #269

merged 1 commit into from
Oct 31, 2023

Conversation

haampie
Copy link
Member

@haampie haampie commented Oct 30, 2023

Didn't update the outputs yet, since we need a new image & buildcache.

@haampie haampie force-pushed the fix/zlib-gmake branch 2 times, most recently from bc4a2ca to 75c391a Compare October 31, 2023 16:36
@haampie haampie requested a review from alalazo October 31, 2023 16:39
alalazo
alalazo approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a starting point to later generate output.

@haampie haampie merged commit 9bebe83 into spack:main Oct 31, 2023
2 checks passed
@haampie haampie deleted the fix/zlib-gmake branch October 31, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalazo alalazo alalazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haampie @alalazo