G3P-X: Use FreeRTOS common app config header file #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-span
requested review from
borgel,
mookerji,
patrick-dojofive,
ellie-dojofive,
brridder and
minchingho
|
See my comment here: https://github.com/spanio/Gen3-Panel/pull/555/files#r1704261068 I'm not sure splitting the configs like this has the intended effect (or any effect as things are currently configured?) |
jl-span
force-pushed
the
jl-span/consolidate-app-cfg-files
branch
from
b31125e to
70a7553
Compare
I think this should be addressed now that |
jl-span
changed the title
ellie-dojofive
approved these changes
Aug 5, 2024
jl-span
force-pushed
the
jl-span/consolidate-app-cfg-files
branch
2 times, most recently
from
7f583fc to
0e8827d
Compare
brridder
approved these changes
Aug 6, 2024
patrick-dojofive
approved these changes
Aug 6, 2024
Remove the setting of the configuration file path here and move it into the application instead.
jl-span
force-pushed
the
jl-span/consolidate-app-cfg-files
branch
from
0e8827d to
ab8ff01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use common FreeRTOSConfig.h
Needed in order to support this refactoring: https://github.com/spanio/Gen3-Panel/pull/555