Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing replacement of loop variable #1890

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix missing replacement of loop variable #1890

merged 2 commits into from
Jan 22, 2025

Conversation

phschaad
Copy link
Collaborator

No description provided.

@phschaad phschaad requested review from pratyai and acalotoiu January 21, 2025 14:39
@phschaad phschaad enabled auto-merge January 21, 2025 14:39
pratyai
pratyai approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@pratyai pratyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

acalotoiu
acalotoiu approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@acalotoiu acalotoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phschaad phschaad added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 1c2d7b5 Jan 22, 2025
9 checks passed
@phschaad phschaad deleted the users/phschaad/loop_variable_replacement_fix branch January 22, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratyai pratyai pratyai approved these changes

@acalotoiu acalotoiu acalotoiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phschaad @pratyai @acalotoiu