Add skip to sdfg dot simplify #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phschaad
requested changes
Jan 22, 2025
dace/sdfg/sdfg.py
Outdated
| return SimplifyPass(validate=validate, | ||
| validate_all=validate_all, | ||
| verbose=verbose, | ||
| skip=options.get('skip', None), |
There was a problem hiding this comment.
you'll have to make sure options is not None first.
There was a problem hiding this comment.
Why doesn't SDFG.simplify have a skip argument? It would be nicer for a user.
There was a problem hiding this comment.
that's probably even better, yes - we should just propagate the argument up to the next API level
There was a problem hiding this comment.
I agree, creating a skip argument is better IMO too.
phschaad
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this change would be convenient, allows us to skip some passes even if we call sdfg.simplify()