Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change range of issueingAuthority from anyURI to string #620

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Change range of issueingAuthority from anyURI to string #620

merged 2 commits into from
Jan 31, 2024

Conversation

goneall
Copy link
Member

@goneall goneall commented Jan 29, 2024

Fixes #568

@goneall goneall mentioned this pull request Jan 30, 2024
Closed
32 tasks
@kestewart kestewart added this to the 3.0-rc2 milestone Jan 30, 2024
kestewart
kestewart approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks reasonable based on the discussion. URI would be machine readable, but if it's going to cause too many problems, per the issue. This should sort it.

@kestewart kestewart added the Profile:Core Core Profile and related matters label Jan 30, 2024
@kestewart kestewart merged commit 6a267fb into main Jan 31, 2024
1 check passed
@kestewart kestewart deleted the goneall-patch-4 branch January 31, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@kestewart kestewart kestewart approved these changes

Assignees
No one assigned
Labels
Profile:Core Core Profile and related matters
Projects
None yet
Milestone
3.0-rc2
Development

Successfully merging this pull request may close these issues.

The "issuingAuthority" property on the ExternalIdentifier class should be of type String rather than anyURI.
3 participants
@goneall @zvr @kestewart