Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese translation for models - Part V #952

Open
wants to merge 19 commits into
base: support/3.0
Choose a base branch
from

Conversation

ZhengZhenyu
Copy link

Add Chinese translation for SimpleLicensing and Software models, this is the last patch for the series.

Add Chinese translation for SimpleLicensing and Software models, this is the last patch for the series.

Signed-off-by: Zhenyu Zheng <[email protected]>
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few formatting requests and a question about how to represent the translated entry names.

model/Software/Classes/ContentIdentifier.md Outdated Show resolved Hide resolved
model/Software/Classes/Package.md Outdated Show resolved Hide resolved
model/Software/Properties/copyrightText.md Outdated Show resolved Hide resolved
model/Software/Properties/packageUrl.md Outdated Show resolved Hide resolved
model/Software/Vocabularies/FileKindType.md Outdated Show resolved Hide resolved
@bact bact added the Translation:zh-Hans Translation for Simplified Chinese label Jan 4, 2025
bact added 4 commits January 5, 2025 04:14
I will commit trivial minor suggested changes here, so we can focus on the question of entry names

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor suggested changes here, so we can focus on the question of entry names

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor suggested changes here, so we can focus on the question of entry names

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor suggested changes here, so we can focus on the question of entry names

Signed-off-by: Arthit Suriyawongkul <[email protected]>
model/SimpleLicensing/Properties/licenseExpression.md Outdated Show resolved Hide resolved
model/SimpleLicensing/Properties/customIdToUri.md Outdated Show resolved Hide resolved
model/Software/Classes/ContentIdentifier.md Show resolved Hide resolved
model/Software/Vocabularies/ContentIdentifierType.md Outdated Show resolved Hide resolved
model/Software/Vocabularies/SbomType.md Outdated Show resolved Hide resolved
bact added 5 commits January 5, 2025 04:22
I will commit trivial minor change suggestions here, so we can focus on the question of entry names.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor change suggestions here, so we can focus on the question of entry names.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor change suggestions here, so we can focus on the question of entry names.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor change suggestions here, so we can focus on the question of entry names.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
I will commit trivial minor change suggestions here, so we can focus on the question of entry names.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr, goneall and kestewart January 5, 2025 04:25
model/Software/Vocabularies/SbomType.md Outdated Show resolved Hide resolved
model/Software/Vocabularies/SoftwarePurpose.md Outdated Show resolved Hide resolved
ZhengZhenyu and others added 2 commits January 20, 2025 14:31
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Zhenyu Zheng <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Zhenyu Zheng <[email protected]>
@ZhengZhenyu ZhengZhenyu requested a review from bact January 20, 2025 06:32
Co-authored-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Zhenyu Zheng <[email protected]>
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few formatting suggestions.

model/SimpleLicensing/Classes/AnyLicenseInfo.md Outdated Show resolved Hide resolved
model/SimpleLicensing/Properties/customIdToUri.md Outdated Show resolved Hide resolved
model/SimpleLicensing/Properties/licenseExpression.md Outdated Show resolved Hide resolved
model/Software/Classes/Package.md Outdated Show resolved Hide resolved
model/Software/Vocabularies/SbomType.md Outdated Show resolved Hide resolved
@gomico
Copy link

gomico commented Jan 21, 2025

The translations appear accurate and well-crafted. The flow and tone align seamlessly with the original English documents.

@helen-ls
Copy link

Reviewed. The organization is logical, and the language flows naturally. The grammar is solid, and the message is communicated clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation:zh-Hans Translation for Simplified Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants