Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print verbose info during PR validation (target: 'develop' branch) #963

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

bact
Copy link
Collaborator

@bact bact commented Jan 23, 2025

  • Show the version of the spec-parser currently working with
  • Add --debug --verbose to spec-parser options to print more information for the PR author to understand why the purposed changes failed the validation (if it failed)

Add --debug to spec-parser options
(--debug is supposed to be more verbose than --verbose)

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the ci Dev workflow and repo management label Jan 23, 2025
@bact bact requested review from zvr, goneall and puerco January 23, 2025 10:47
Signed-off-by: Arthit Suriyawongkul <[email protected]>

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr
Copy link
Member

zvr commented Jan 23, 2025

What is the purpose of the "validation"?
I assume to make sure that the input is "correct" / "valid".

What does this mean?
More specifically:

  • errors should most definitely be flagged
  • what about warnings?

And how is it checked?

  • is only the exit code of the process?
  • or is the generated output / error messages also checked?

@bact bact changed the title Print debug information during PR validation (target: 'develop' branch) Print verbose output during PR validation (target: 'develop' branch) Jan 23, 2025
@bact
Copy link
Collaborator Author

bact commented Jan 23, 2025

If it's valid it's good.

If it's not, having some information to understand why it is the case is good.

@bact bact changed the title Print verbose output during PR validation (target: 'develop' branch) Print verbose info during PR validation (target: 'develop' branch) Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Dev workflow and repo management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants