Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spdx3-validate to examples validation workflow #1134

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

bact
Copy link
Collaborator

@bact bact commented Oct 8, 2024

Also print validation setup (URLs and tool versions)

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Can be useful for debug during version updates
Signed-off-by: Arthit Suriyawongkul <[email protected]>
More quick clues for code readers

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added the ci Dev workflow and repo management label Oct 8, 2024
@bact bact marked this pull request as draft October 8, 2024 04:23
@bact
Copy link
Collaborator Author

bact commented Oct 8, 2024

Validation failed due to individual-related issue. Turn to draft for now.

@bact bact marked this pull request as ready for review November 15, 2024 17:49
@bact bact added this to the 3.1 milestone Nov 19, 2024
@bact bact requested review from maxhbr and goneall November 19, 2024 01:53
@bact
Copy link
Collaborator Author

bact commented Nov 19, 2024

The validation script can run and print results as expected.
(But the validation result of the file being tested is failed)

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall
Copy link
Member

goneall commented Nov 19, 2024

It looks like the validation is failing - it also failed on a previous PR - so likely not do to these changes.

@bact - if you find the source of the failure, can you include a fix in this PR?

@bact
Copy link
Collaborator Author

bact commented Nov 19, 2024

@goneall the validation fail is from the known issue of missing CreationInfo for individuals.

We need to add it when generating the ontology file, with this PR spdx/spec-parser#154 or similar.

@bact
Copy link
Collaborator Author

bact commented Dec 5, 2024

@goneall @zvr @ilans the CreationInfo issue is probably fixed now. But because of the assessedElement range update, the example failed. I will update the example and check again.

@bact
Copy link
Collaborator Author

bact commented Dec 6, 2024

@goneall @zvr @ilans The old 5 violations about missing CreationInfo are fixed.
But we have new violations about new 5 cretionInfo_*.

I opened a separated issue for that at spdx/spdx-3-model#936

Temporary skip pyshacl to see the results of spdx3-validate

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact requested review from zvr and goneall December 10, 2024 20:41
@bact
Copy link
Collaborator Author

bact commented Dec 10, 2024

Example validation is passed now.

@bact bact requested a review from kestewart December 29, 2024 05:05
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Dev workflow and repo management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants