-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spdx3-validate to examples validation workflow #1134
base: develop
Are you sure you want to change the base?
Conversation
Also print validation setup (URLs and tool versions) Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Can be useful for debug during version updates Signed-off-by: Arthit Suriyawongkul <[email protected]>
More quick clues for code readers Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Validation failed due to individual-related issue. Turn to draft for now. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
The validation script can run and print results as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @bact
It looks like the validation is failing - it also failed on a previous PR - so likely not do to these changes. @bact - if you find the source of the failure, can you include a fix in this PR? |
@goneall the validation fail is from the known issue of missing CreationInfo for individuals. We need to add it when generating the ontology file, with this PR spdx/spec-parser#154 or similar. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall @zvr @ilans The old 5 violations about missing CreationInfo are fixed. I opened a separated issue for that at spdx/spdx-3-model#936 |
Temporary skip pyshacl to see the results of spdx3-validate Signed-off-by: Arthit Suriyawongkul <[email protected]>
…into use-spdx3-validate
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Example validation is passed now. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
bin/check-examples.sh
to print relevant environment variables to assist debuggingsoftware_packageVersion
inexamples/jsonld/package_sbom.json
to match the version appears in thesoftware_downloadLocation