Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Correct COT Selection in QB When Sharing Formatters #6252

Open
wants to merge 7 commits into
base: production
Choose a base branch
from
Open

Ensure Correct COT Selection in QB When Sharing Formatters #6252

wants to merge 7 commits into from
+48 −8

Conversation

Areyes42
Copy link
Contributor

@Areyes42 Areyes42 commented Feb 17, 2025 •
edited
Loading

Fixes #5503

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)

Testing instructions

  1. Create two CollectionObjectTypes with the same Catalog Number Format Name which differs from that of the Collection's default Catalog Number format
  2. Create a new Collection Object query, add Catalog Number to the query, and switch the type from Any to Equal
  3. Try to select both COTs
  • Verify that it selects the proper COT regardless of the Catalog Number format

@Areyes42 Areyes42 linked an issue Feb 17, 2025 that may be closed by this pull request
Query Builder: Can't select a COT for Catalog Number if it shares a formatter with another COT #5503
Open
@Areyes42 @github-actions
Lint code with ESLint and Prettier
5911b8d 
Triggered by fed7786 on branch refs/heads/issue-5503
@CarolineDenis CarolineDenis added this to the 7.10.2 milestone Feb 21, 2025
@Areyes42 Areyes42 marked this pull request as ready for review February 21, 2025 19:15
@Areyes42 Areyes42 requested a review from a team February 21, 2025 19:15
sharadsw
sharadsw requested changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@sharadsw sharadsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your approach. Functionally your code looks good, just pointing out some minor code smells.

@Areyes42
Copy link
Contributor Author

I like your approach. Functionally your code looks good, just pointing out some minor code smells.

Good point, I've added some helpers to separate the logic and hopefully make it a little more intuitive. Let me know if you think this looks better!

@Areyes42 Areyes42 requested a review from sharadsw February 21, 2025 22:24
sharadsw
sharadsw approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@sharadsw sharadsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharadsw sharadsw sharadsw approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: Dev Attention Needed
Milestone
7.10.2
Development

Successfully merging this pull request may close these issues.

Query Builder: Can't select a COT for Catalog Number if it shares a formatter with another COT
3 participants
@Areyes42 @sharadsw @CarolineDenis