Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TAS Shapecast #3661

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Fixed TAS Shapecast #3661

merged 4 commits into from
Dec 10, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Dec 9, 2024

Description & motivation

Fixes issue https://linear.app/speckle/issue/WEB-2162/tas-only-shapecast-is-incorrect reported here

Changes:

  • intersectTASRange now correctly receives all valid BatchObjects
  • intersectTASRange only recieves a BatchObject once
  • TAS shapecast now 4X times faster
  • Additionally this seems to have fixed a very old issue that was also reported by Nickos, where the section outlines would sometimes not get properly generated for some objects

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…n all batch objects, missing some of them. Some small updates to BoxSelection
…once to intersectTASRange and also added the builtin CONTAINED acceleration to bounds testing.
Copy link

linear bot commented Dec 9, 2024

Copy link
Contributor

github-actions bot commented Dec 9, 2024

📸 Preview service has generated an image.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

📸 Preview service has generated an image.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit e7613a6 into main Dec 10, 2024
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2162 branch December 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants