Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewer-lib): Bad vertex color counts are now ignored #3809

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fix(viewer-lib): Bad vertex color counts are now ignored #3809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d75fe86
fix(viewer-lib): Fixed an issue where mismatched vertex color counts …
AlexandruPopovici Jan 14, 2025
94b2d14
Merge branch 'main' into alex/vertex-colors-mismatch-fix
AlexandruPopovici Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/viewer-sandbox/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,12 +459,14 @@ const getStream = () => {
// 'https://speckle.xyz/streams/27e89d0ad6/commits/5ed4b74252'

//Gingerbread
'https://latest.speckle.systems/projects/387050bffe/models/48f7eb26fb'
// 'https://latest.speckle.systems/projects/387050bffe/models/48f7eb26fb'
// DUI3 Mesh Colors
// 'https://app.speckle.systems/projects/93200a735d/models/cbacd3eaeb@344a397239'

// Instance toilets
// 'https://app.speckle.systems/projects/e89b61b65c/models/2a0995f124'

'https://latest.speckle.systems/projects/3fe1880c36/models/65bb4287a8'
)
}

Expand Down
4 changes: 2 additions & 2 deletions packages/viewer/src/modules/loaders/Speckle/SpeckleGeometryConverter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,9 @@ export class SpeckleGeometryConverter extends GeometryConverter {
Logger.warn(
`Mesh (id ${node.raw.id}) colours are mismatched with vertice counts. The number of colours must equal the number of vertices.`
)
}
} else
/** We want the colors in linear space */
colors = this.unpackColors(colorsRaw, true)
colors = this.unpackColors(colorsRaw, true)
}

return {
Expand Down
Loading