PassReader updates for View Modes #3828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlying viewer library updates Implemented reading framebuffer contents for framebuffers with multiple attachements. The current version of three.js that we are using does not support this. Because we still need to drag along WebGL 1.0 support, only attachement 0 can be read for now, which does not bother us. DepthNormalPass now specifies it's MRT output target as the outputTarget PassReader's read function is now overloaded and it can take a pass name as a string or a GPass | GPass[] Had to add a small type augmentation since the current version of types-three library does a poor job when it comes to WebGLMultipleRenderTargets Updated PassReader extension in frontend and updated the call to read in order to make sure depth reading works in other view modes that write depth. The only view mode that does not draw to depth is Shaded mode
didimitrie
previously approved these changes
Jan 15, 2025
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
…r view mode pipelines
|
📸 Preview service has generated an image. |
didimitrie
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR makes it possible to read the depth image data when in other view modes. The only view mode that does not support this is "Shaded" mode, aka BasitMode
Changes:
DepthNormalPassnow specifies it's MRT output target as theoutputTargetPassReader's read function is now overloaded and it can take a pass name as a string or aGPass | GPass[]WebGLMultipleRenderTargetsPassReaderextension in frontend and updated the call to read in order to make sure depth reading works in other view modes that write depth. The only view mode that does not draw to depth is Shaded modeTo-do before merge:
Screenshots:
Validation of changes:
Checklist:
References