fix(server): dataloader batching being broken #3838
+97
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ever since multi region dataloaders, they were not properly batching up SQL queries
for that big connectors query this reduced SQL counts from 121 to 42 locally, and that is with multiple regions, where each region has to have its own cache and query. so the number will be even lower for people with all data in the same region
edit: also introduced Stream/Project.collaborators dataloader, which cut that 42 SQL op count in half down to just 18