Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): dataloader batching being broken #3838

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Jan 16, 2025

ever since multi region dataloaders, they were not properly batching up SQL queries

for that big connectors query this reduced SQL counts from 121 to 42 locally, and that is with multiple regions, where each region has to have its own cache and query. so the number will be even lower for people with all data in the same region

edit: also introduced Stream/Project.collaborators dataloader, which cut that 42 SQL op count in half down to just 18

iainsproat
iainsproat previously approved these changes Jan 16, 2025
@fabis94 fabis94 requested a review from iainsproat January 16, 2025 12:00
iainsproat
iainsproat previously approved these changes Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants