Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTE Fix for MacOS and iOS #3907

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Jan 28, 2025

Description & motivation

Found a workaround for the RTE issues we've been having on macOS and iOS after Apple made some updates. Fixes https://linear.app/speckle/issue/WEB-470/far-off-origin-geometries-broken-again-on-apple
Before:
Screenshot 2025-01-28 at 19 25 18

After:
Screenshot 2025-01-28 at 19 24 42

Also fixes MRTDepthNormal pass for intel Xe integrated GPU

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

📸 Preview service has generated an image.

Copy link

linear bot commented Jan 29, 2025

@AlexandruPopovici AlexandruPopovici merged commit 0cd9487 into main Jan 29, 2025
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/apple-RTE-fix-woohoo branch January 29, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants