Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements on the History API #160

Draft
wants to merge 43 commits into
base: staging
Choose a base branch
from

Conversation

racoelhosilva
Copy link

@racoelhosilva racoelhosilva commented Jul 26, 2024

History of Transformations based on operation instances

Description

This pull request brings two fixes and improvements to the history of transformations API. While the issues are not fixed yet, the changes assume that they are working as agreed and should integrate with them later on.

Assumed fixes

  • Analyze the Joinpoint action replaceWith(Joinpoint[]) as it is causing some issues (a test for this function is now testing if the method works as expected) - as of this commit in the Lara Framework, this is now fixed
  • Change the return values of setFirstChild and setLastChild from void to the Joinpoint that previously existed there (assuming this new return value, the API has some internal changes to improve architecture and logic)

References

  • The History API previously mentioned is the one from this pull request, obviously, these fixes should only be merged if that pull request has been previously merged

This work is related to the topic [CSE02] Recording the History of Source-to-Source Transformations, which is part of the INESC TEC Summer Internship 2024

@joaobispo joaobispo changed the base branch from feature/clava-js to staging August 12, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant