Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webhook-disable.md #5598

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Update webhook-disable.md #5598

merged 5 commits into from
Feb 12, 2025

Conversation

hausmckinney
Copy link
Contributor

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
reconcile:

  • files
    • name: "Redirect registries" - path: /etc/containerd/certs.d/gcr.io/hosts.toml owner: 0 group: 0 permissions: 0644 content: |- server = "https://gcr.io" [host."https://gcr-io-mirror.company.local"] capabilities = ["pull", "resolve"]

Describe the Change

This PR ....

Changed Pages

💻 Add Preview URL for Page

Jira Tickets

🎫 Jira Ticket

Backports

Can this PR be backported?

  • Yes. Remember to add the relevant backport labels to your PR.
  • No. Please leave a short comment below about why this PR cannot be backported.

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
  reconcile:
   - files
      - name: "Redirect registries"
         - path: /etc/containerd/certs.d/gcr.io/hosts.toml
           owner: 0
           group: 0
           permissions: 0644
           content: |-
             server = "https://gcr.io"
             [host."https://gcr-io-mirror.company.local"]
                 capabilities = ["pull", "resolve"]
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit 6533344
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/67acf1fc735fff0008ab515f
😎 Deploy Preview https://deploy-preview-5598--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lennessyy lennessyy requested a review from kreeuwijk February 12, 2025 17:40
Copy link
Contributor

@kreeuwijk kreeuwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite correct, replace with:

   ```yaml {9-11}
   stages:
     reconcile:
       - name: "Redirect registries"
         files:
           - path: /etc/containerd/certs.d/gcr.io/hosts.toml
             owner: 0
             group: 0

@lennessyy lennessyy requested a review from kreeuwijk February 12, 2025 18:54
Copy link
Contributor

@kreeuwijk kreeuwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lennessyy you need to make sure that path, owner and group are on the same indentation as permissions and content

Copy link
Contributor

@kreeuwijk kreeuwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lennessyy lennessyy added auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch. labels Feb 12, 2025
@lennessyy lennessyy merged commit 967d313 into master Feb 12, 2025
18 checks passed
@lennessyy lennessyy deleted the hausmckinney-patch-4 branch February 12, 2025 19:25
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Feb 12, 2025
* Update webhook-disable.md

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
  reconcile:
   - files
      - name: "Redirect registries"
         - path: /etc/containerd/certs.d/gcr.io/hosts.toml
           owner: 0
           group: 0
           permissions: 0644
           content: |-
             server = "https://gcr.io"
             [host."https://gcr-io-mirror.company.local"]
                 capabilities = ["pull", "resolve"]

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/webhook-disable.md

* Update webhook-disable.md

* docs: fix indentation

---------

Co-authored-by: Adelina Simion <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit 967d313)
@vault-token-factory-spectrocloud
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
version-4-4 Backport failed because of merge conflicts
version-4-5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

backport --pr 5598

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

vault-token-factory-spectrocloud bot added a commit that referenced this pull request Feb 12, 2025
* Update webhook-disable.md

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
  reconcile:
   - files
      - name: "Redirect registries"
         - path: /etc/containerd/certs.d/gcr.io/hosts.toml
           owner: 0
           group: 0
           permissions: 0644
           content: |-
             server = "https://gcr.io"
             [host."https://gcr-io-mirror.company.local"]
                 capabilities = ["pull", "resolve"]

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/webhook-disable.md

* Update webhook-disable.md

* docs: fix indentation

---------

Co-authored-by: Adelina Simion <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
(cherry picked from commit 967d313)

Co-authored-by: hausmckinney <[email protected]>
benradstone pushed a commit that referenced this pull request Feb 13, 2025
* Update webhook-disable.md

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
  reconcile:
   - files
      - name: "Redirect registries"
         - path: /etc/containerd/certs.d/gcr.io/hosts.toml
           owner: 0
           group: 0
           permissions: 0644
           content: |-
             server = "https://gcr.io"
             [host."https://gcr-io-mirror.company.local"]
                 capabilities = ["pull", "resolve"]

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/webhook-disable.md

* Update webhook-disable.md

* docs: fix indentation

---------

Co-authored-by: Adelina Simion <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
benradstone added a commit that referenced this pull request Feb 14, 2025
* docs: initial prepare env template

* chore: bump react-select from 5.8.0 to 5.10.0 (#5621)

Bumps [react-select](https://github.com/JedWatson/react-select) from 5.8.0 to 5.10.0.
- [Release notes](https://github.com/JedWatson/react-select/releases)
- [Changelog](https://github.com/JedWatson/react-select/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/JedWatson/react-select/compare/[email protected]@5.10.0)

---
updated-dependencies:
- dependency-name: react-select
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: caroldelwing <[email protected]>

* chore: bump @commitlint/cli from 19.5.0 to 19.6.1 (#5620)

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 19.5.0 to 19.6.1.
- [Release notes](https://github.com/conventional-changelog/commitlint/releases)
- [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md)
- [Commits](https://github.com/conventional-changelog/commitlint/commits/v19.6.1/@commitlint/cli)

---
updated-dependencies:
- dependency-name: "@commitlint/cli"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: caroldelwing <[email protected]>

* chore: bump @mdx-js/react from 3.0.1 to 3.1.0 (#5617)

Bumps [@mdx-js/react](https://github.com/mdx-js/mdx/tree/HEAD/packages/react) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/mdx-js/mdx/releases)
- [Changelog](https://github.com/mdx-js/mdx/blob/main/changelog.md)
- [Commits](https://github.com/mdx-js/mdx/commits/3.1.0/packages/react)

---
updated-dependencies:
- dependency-name: "@mdx-js/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* docs: add extra sentence, fix command (#5669)

* chore: bump @argos-ci/playwright from 2.0.0 to 4.1.0 (#5619)

Bumps [@argos-ci/playwright](https://github.com/argos-ci/argos-javascript/tree/HEAD/packages/playwright) from 2.0.0 to 4.1.0.
- [Release notes](https://github.com/argos-ci/argos-javascript/releases)
- [Changelog](https://github.com/argos-ci/argos-javascript/blob/main/packages/playwright/CHANGELOG.md)
- [Commits](https://github.com/argos-ci/argos-javascript/commits/@argos-ci/[email protected]/packages/playwright)

---
updated-dependencies:
- dependency-name: "@argos-ci/playwright"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: caroldelwing <[email protected]>

* Removing erroneous EOF from .arg file (#5682)

* docs: EKS cluster and EKS hybrid requirements (#5661)

* docs: EKS cluster and EKS hybrid requirements

* ci: auto-formatting prettier issues

* docs: vale suggestion

* ci: auto-formatting prettier issues

* docs: fix CNI steps

* docs: additional requirements for instance

* ci: auto-formatting prettier issues

* docs: revise minimum storage for eks nodes

* docs: finalise recommended storage for eks workers

* docs: adjust release note to include control plane resize operations (#5683)

* docs: adjust release note to include control plane resize operations

* Update docs/docs-content/release-notes/release-notes.md

Co-authored-by: caroldelwing <[email protected]>

* docs: update wording release notes

---------

Co-authored-by: caroldelwing <[email protected]>

* docs: agent mode drafting

* docs: minor EKS description change (#5689)

* chore: bump semver from 7.6.3 to 7.7.1 (#5654)

Bumps [semver](https://github.com/npm/node-semver) from 7.6.3 to 7.7.1.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.6.3...v7.7.1)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: caroldelwing <[email protected]>

* docs: finalise agent mode draft

* docs: add os upgrades guide DOC-1533 (#5647)

* docs: add os upgrades guide DOC-1533

* docs: change phrasing and add reboot

* ci: auto-formatting prettier issues

* remove shorthand

* Apply suggestions from code review

Co-authored-by: Lenny Chen <[email protected]>

* Apply suggestions from code review

Co-authored-by: caroldelwing <[email protected]>

* ci: auto-formatting prettier issues

* docs: fix indentation of cat command

* docs: add changes from review

* docs: shorten output

* docs: address comments from review

* docs: changes for review DOC-1533

---------

Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: caroldelwing <[email protected]>

* docs: Appliance Mode step for hybrid pool creation (#5704)

* docs: Appliance Mode step for hybrid pool creation

* ci: auto-formatting prettier issues

* docs: fix prettier formatting

* Apply suggestions from code review

Co-authored-by: Amanda Churi Filanowski <[email protected]>

---------

Co-authored-by: Amanda Churi Filanowski <[email protected]>

* docs: update the release preview workflow to more specific branch matching (#5693)

* docs: appliance mode draft and other edits

* docs: finalise appliance mode and refactoring

* docs: add notes for patch 4.5.22 DOC-1692 (#5720)

* docs: add notes for patch 4.5.22 DOC-1692

* ci: auto-formatting prettier issues

* Update webhook-disable.md (#5598)

* Update webhook-disable.md

Per Customer:
Step 9 is missing the “files” line (I added line 3 to show):

stages:
  reconcile:
   - files
      - name: "Redirect registries"
         - path: /etc/containerd/certs.d/gcr.io/hosts.toml
           owner: 0
           group: 0
           permissions: 0644
           content: |-
             server = "https://gcr.io"
             [host."https://gcr-io-mirror.company.local"]
                 capabilities = ["pull", "resolve"]

* Update docs/docs-content/clusters/edge/site-deployment/deploy-custom-registries/webhook-disable.md

* Update webhook-disable.md

* docs: fix indentation

---------

Co-authored-by: Adelina Simion <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>

* docs: update 4.5.21 upgrade paths and helm paths (#5722)

* docs: DOC-1634: Calico Memory Leak and Palette Workload Clusters (#5726)

* Update to known issue specifying all Palette workload clusters are affected

* ci: auto-formatting prettier issues

---------

Co-authored-by: achuribooks <[email protected]>

* Removing internet connectivity limitation from Palette CLI ec command (#5728)

* docs: fix missing file extension from link

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: caroldelwing <[email protected]>
Co-authored-by: Amanda Churi Filanowski <[email protected]>
Co-authored-by: Adelina Simion <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: hausmckinney <[email protected]>
Co-authored-by: Lenny Chen <[email protected]>
Co-authored-by: achuribooks <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-4 Backport change to version 4.4 backport-version-4-5 Backport changes to the version-4-5 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants