Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Better-connect-bar snippet #824

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add Better-connect-bar snippet #824

wants to merge 2 commits into from

Conversation

ZGQ-inc
Copy link

@ZGQ-inc ZGQ-inc commented Aug 17, 2024

No description provided.

@ZGQ-inc ZGQ-inc requested a review from a team as a code owner August 17, 2024 09:46
@ZGQ-inc ZGQ-inc requested review from Delusoire and removed request for a team August 17, 2024 09:46
@ZGQ-inc ZGQ-inc changed the title add Better-connect-bar snippets feat: add Better-connect-bar snippets Aug 17, 2024
@ZGQ-inc ZGQ-inc changed the title feat: add Better-connect-bar snippets feat: add Better-connect-bar snippet Aug 17, 2024
kyrie25
kyrie25 reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the snippet still working/relevant

@ZGQ-inc
Copy link
Author

ZGQ-inc commented Jan 21, 2025 •
edited
Loading

Is the snippet still working/relevant

It still works on my Spotify version 1.2.53.440.
By the way, I don't know since which version they changed the border-radius from 4px to 8px, whatever.

@kyrie25
Copy link
Member

kyrie25 commented Jan 21, 2025

It still works on my Spotify version 1.53.440. By the way, I don't know since which version they changed the border-radius from 4px to 8px, whatever.

The current latest Spotify version is 1.2.55, can you check and see if it still works there?

kyrie25
kyrie25 requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve syntax issue

@ZGQ-inc
Copy link
Author

ZGQ-inc commented Jan 21, 2025

The current latest Spotify version is 1.2.55, can you check and see if it still works there?

Tested on 1.2.55.235, it works, and they changed border-radius back to 4px.

@kyrie25
Copy link
Member

kyrie25 commented Jan 21, 2025

Tested on 1.2.55.235, it works, and they changed border-radius back to 4px.

Nice! I'll look into it after you've resolved the issues, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrie25 kyrie25 kyrie25 requested changes

@Delusoire Delusoire Awaiting requested review from Delusoire Delusoire is a code owner automatically assigned from spicetify/marketplace

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZGQ-inc @kyrie25