Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto update plugin manifest in index repo on tagged releases #56

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

rajatjindal
Copy link
Collaborator

No description provided.

Copy link
Contributor

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this action also runs for pushes to branches matching "v[0-9]+.[0-9]+" -- just double-checking that the 'Release Plugin' step should run in these cases as well.

@rajatjindal
Copy link
Collaborator Author

I see this action also runs for pushes to branches matching "v[0-9]+.[0-9]+" -- just double-checking that the 'Release Plugin' step should run in these cases as well.

that is a good point. I don't think we need to run this action for "v[0-9]+.[0-9]+"` unless there is a specific requirement. do you see any issue if we just remove that part from the trigger config?

@vdice
Copy link
Contributor

vdice commented Mar 11, 2024

do you see any issue if we just remove that part from the trigger config?

No, althought I haven't really been tuned in to this repo and its CI needs. But if we we don't need that trigger for this workflow, sounds good, we should remove.

@bacongobbler
Copy link
Collaborator

bacongobbler commented Mar 12, 2024

I don't think we need to run this action for "v[0-9]+.[0-9]+"` unless there is a specific requirement.

I'm confused. I thought that was the whole point of this PR. If we tag v0.1.0, this change will now add v0.1.0 to the index.

Can you please help catch me up on the context behind this change?

@bacongobbler
Copy link
Collaborator

Oh wait you're talking about BRANCHES, not tags. Sounds good to me!

Signed-off-by: Matthew Fisher <[email protected]>
@bacongobbler bacongobbler merged commit 67f3f0c into main Mar 12, 2024
1 check passed
@bacongobbler bacongobbler deleted the enable-auto-releases branch March 12, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants