test(web): add Retrofit2ServiceFactoryTest to test the creation of retrofit2 client using Retrofit2ServiceFactory #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
reviewed
Jan 9, 2025
...retrofit2/src/test/java/com/netflix/spinnaker/kork/retrofit/Retrofit2ServiceFactoryTest.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Jan 9, 2025
kork-retrofit2/src/test/java/com/netflix/spinnaker/kork/retrofit/Retrofit2TestConfig.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Jan 9, 2025
kork-retrofit2/src/test/java/com/netflix/spinnaker/kork/retrofit/Retrofit2TestService.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
retrofit2service-factory-test
branch
2 times, most recently
from
be469c5 to
efdb5c2
Compare
dbyron-sf
reviewed
Jan 10, 2025
kirangodishala
force-pushed
the
retrofit2service-factory-test
branch
2 times, most recently
from
6785fc4 to
ddb0bdb
Compare
…trofit2 client using Retrofit2ServiceFactory
kirangodishala
force-pushed
the
retrofit2service-factory-test
branch
from
ddb0bdb to
f79b5ec
Compare
dbyron-sf
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test coverage to the following classes by creating a retrofit2 client: Retrofit2ServiceFactory, DefaultServiceClientProvider, OkHttpClientProvider.