-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The current ArrayMetadata system was put together somewhat quickly and uses `serde` + Flexbuffers to serialize all metadata. The end state looks like this: - [ ] An array has a fixed 8 bytes of metadata. If it needs more, it should use a buffer (made possible by #1743) - [ ] Rkyv can optionally be used to help with serde for these bytes. - [ ] No eager deserialization of metadata is performed, although arrays should validate metadata in the `ValidateVTable` (see #1979). To support 8 byte metadata, we need to: - [ ] Move scalars and scalar values out of metadata (e.g. ConstantArray) - [ ] Move shift from FoR into BitPacking (this is a bit cheeky, it's not strictly necessary, but FoR is then left with a 8-byte PValue for metadata, and shifting feels like it should live in BitPacking anyway?) - [ ] All other metadata should easily fit into 8 bytes.
- Loading branch information
Showing
59 changed files
with
1,004 additions
and
521 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.