make traversal module in vortex-expr public (#2104)

spiraldb · Jan 28, 2025 · f17f32e · f17f32e
1 parent e81bd76
commit f17f32e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/vortex-expr/src/lib.rs b/vortex-expr/src/lib.rs
@@ -22,8 +22,7 @@ mod pack;
 pub mod pruning;
 mod select;
 pub mod transform;
-#[allow(dead_code)]
-mod traversal;
+pub mod traversal;
 
 pub use binary::*;
 pub use get_item::*;

diff --git a/vortex-expr/src/transform/mod.rs b/vortex-expr/src/transform/mod.rs
@@ -3,6 +3,6 @@ pub mod field_mask;
 pub mod immediate_access;
 pub mod partition;
 mod remove_merge;
-pub(crate) mod remove_select;
+mod remove_select;
 pub mod simplify;
 pub mod simplify_typed;
diff --git a/vortex-expr/src/traversal/mod.rs b/vortex-expr/src/traversal/mod.rs
@@ -3,6 +3,7 @@ mod visitor;
 
 use itertools::Itertools;
 pub use references::ReferenceCollector;
+pub use visitor::{pre_order_visit_down, pre_order_visit_up};
 use vortex_error::VortexResult;
 
 use crate::ExprRef;

diff --git a/vortex-expr/src/traversal/references.rs b/vortex-expr/src/traversal/references.rs
@@ -5,6 +5,7 @@ use vortex_error::VortexResult;
 use crate::traversal::{NodeVisitor, TraversalOrder};
 use crate::{ExprRef, GetItem, Select};
 
+#[derive(Default)]
 pub struct ReferenceCollector {
     fields: HashSet<FieldName>,
 }