feat: alp compare v2 #2071
Merged
feat: alp compare v2 #2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
approved these changes
Jan 27, 2025
|
Hmm, I might be missing something, but most of the time the encoded values will be bitpacked, and we don't seem to support CompareFn for bitpacked, so even with this change most of the time we'll still canonicalize, just one level deeper. Is that right? |
|
I believe so, but canon into smaller ints might be better than into floats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alp compare (v2), without patches & nullability (for now). 3 tpch queries will use this code path.
Seems like the fuzzer can help with the correctness checks (TODO).
old compare #1603