Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose conditional puts in the FileIO interface #1

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Expose conditional puts in the FileIO interface #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/iceberg/src/io/file_io.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,16 @@ impl OutputFile {
writer.close().await
}

/// Create a new output file with given bytes.
/// Error out if the file already exists
pub async fn write_exclusive(&self, bs: Bytes) -> crate::Result<()> {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naming suggestions for this method are welcome. I named it write_exclusive after O_EXCL in the Linux/Unix API which has equivalent functionality

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Might be useful if OutputFile::op was exposed upstream eventually, then we'd be able to do the same without the custom change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Maybe I could simplify this PR to just add a getter for OutputFile::op. That could be easier to get merged upstream.

self.op
.write_with(&self.path[self.relative_path_pos..], bs)
.if_none_match("*")
.await?;
Ok(())
}

/// Creates output file for continues writing.
///
/// # Notes
Expand Down
Loading