feat(service/azfile): add azure file service support (apache#3312)

* feat: add azure file service support Signed-off-by: Liuqing Yue <[email protected]> * feat: add azure file list operation Signed-off-by: Liuqing Yue <[email protected]> * fix: parent path should exist Signed-off-by: Liuqing Yue <[email protected]> * fix: make clippy happy * docs: polish * fix: solve comments --------- Signed-off-by: Liuqing Yue <[email protected]>
splitgraph · Oct 17, 2023 · 8c6e7db · 8c6e7db
1 parent 12becec
commit 8c6e7db
Show file tree

Hide file tree

Showing 14 changed files with 1,427 additions and 3 deletions.
diff --git a/.env.example b/.env.example
@@ -186,3 +186,10 @@ OPENDAL_D1_DATABASE_ID=<database_id>
 OPENDAL_D1_TABLE=<table>
 OPENDAL_D1_KEY_FIELD=<key_field>
 OPENDAL_D1_VALUE_FIELD=<value_field>
+# azfile
+OPENDAL_AZFILE_TEST=false
+OPENDAL_AZFILE_ENDPOINT=<endpoint>
+OPENDAL_AZFILE_ROOT=/tmp/opendal/
+OPENDAL_AZFILE_ACCOUNT_NAME=<account_name>
+OPENDAL_AZFILE_ACCOUNT_KEY=<account_key>
+OPENDAL_AZFILE_SHARE_NAME=<shared_name>
diff --git a/core/Cargo.toml b/core/Cargo.toml
@@ -50,6 +50,7 @@ default = [
   "services-s3",
   "services-webdav",
   "services-webhdfs",
+  "services-azfile",
 ]
 
 # Build docs or not.
@@ -180,6 +181,7 @@ services-wasabi = [
 ]
 services-webdav = []
 services-webhdfs = []
+services-azfile = []
 
 [lib]
 bench = false

diff --git a/core/src/services/azdls/docs.md b/core/src/services/azdls/docs.md
@@ -45,9 +45,9 @@ use opendal::Operator;
 
 #[tokio::main]
 async fn main() -> Result<()> {
-    // Create azblob backend builder.
+    // Create azdls backend builder.
     let mut builder = Azdls::default();
-    // Set the root for azblob, all operations will happen under this root.
+    // Set the root for azdls, all operations will happen under this root.
     //
     // NOTE: the root must be absolute path.
     builder.root("/path/to/dir");

diff --git a/core/src/services/azdls/error.rs b/core/src/services/azdls/error.rs
@@ -77,7 +77,7 @@ pub async fn parse_error(resp: Response<IncomingAsyncBody>) -> Result<Error> {
     };
 
     let mut message = match de::from_reader::<_, AzdlsError>(bs.clone().reader()) {
-        Ok(azblob_err) => format!("{azblob_err:?}"),
+        Ok(azdls_err) => format!("{azdls_err:?}"),
         Err(_) => String::from_utf8_lossy(&bs).into_owned(),
     };
     // If there is no body here, fill with error code.