Iceberg sync #771
Merged
Iceberg sync #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruuya
reviewed
Dec 31, 2024
| @@ -609,3 +609,70 @@ async fn test_sync_custom_store( | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_sync_iceberg_custom_store( | |||
There was a problem hiding this comment.
Seems like test_sync_custom_store and this test share the setup/results, maybe we can just parametrize the former to do exercise this routine for both formats (we can ditch the local parametrization in it since it won't work for Iceberg)?
There was a problem hiding this comment.
The setup, verification and parametrization are all subtly different so I'm not sure it's worth it.
gruuya
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Iceberg tables as sync targets