Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported currencies #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RhysStansfield
Copy link

A simple method for quickly grabbing supported currencies from a store, similar idea to the config options for supported_currencies but per store.

@JDutil
Copy link
Member

JDutil commented Feb 9, 2015

👍

@RhysStansfield
Copy link
Author

One thing I was thinking about - should we have it return currency objects
(like supported_currencies does) or stick with just grabbing the iso-code
strings?

On 9 February 2015 at 21:55, Jeff Dutil [email protected] wrote:

[image: 👍]


Reply to this email directly or view it on GitHub
#4 (comment)
.

@JDutil
Copy link
Member

JDutil commented Feb 9, 2015

You should probably have them return the same currency objects for consistency.

@RhysStansfield
Copy link
Author

Will do so and update PR. :D

On 9 February 2015 at 22:02, Jeff Dutil [email protected] wrote:

You should probably have them return the same currency objects for
consistency.


Reply to this email directly or view it on GitHub
#4 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants