Development has been made to override the relevant phase in child POMs. #370
Conversation
|
@spencergibb Why hasn't my pull request been merged? I want to configure the Antrun plugin in Spring Cloud Stream, and I need this. Why was it closed without any explanation? |
|
This repo is typically not one we get many contributions for because it is for only for use with the spring cloud project and you did not mention that in the beginning. Can I ask what you need it for in Spring Cloud Stream? |
|
Ok, I am sorry @spencergibb. I made a development in Spring Cloud Stream that injects the project.version into a class at build time using the Antrun plugin. However, in the spring-cloud-build project, the Antrun plugin is configured with different settings, and the spring-cloud-stream project uses spring-cloud-build as its parent POM. I don't want the phase you specified for the Antrun plugin to execute, so I will set it to none. For this reason, I made this development and opened a pull request for this project. Additionally, I am very eager to contribute to open source projects and put in significant effort to do so. Additionally, if you find this development appropriate, I would like to reopen the pull request. Moreover, I would be delighted if you could merge my commit. Once this commit is merged, I will continue working on the development. My development in spring cloud stream : spring-cloud/spring-cloud-stream@a8fb34d |
|
We had to revert that commit because of failures. spring-cloud/spring-cloud-stream@e14bc1c I'll work with @sobychacko and @olegz if/when it is reintroduced, we can then revisit this. |
|
spring-cloud/spring-cloud-stream#3027 (comment) @spencergibb . As I explained in the link above, the solution to the issue is to set the phases to none. |
|
Great. My previous statement stands
|
I want to be able to configure this phase in child POMs in certain cases, so I made this change.