Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a condition 'DoNotReplaceQueryParams' paramerter for ProxyExchangeHandlerFunction in GatewayMvc #3248

Closed
wants to merge 7 commits into from

Conversation

sunhao1256
Copy link
Contributor

@sunhao1256 sunhao1256 commented Feb 1, 2024

#3247

Add a condition 'DoNotReplaceQueryParams' paramerter for ProxyExchangeHandlerFunction in GatewayMvc

@pivotal-cla
Copy link

@sunhao1256 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@sunhao1256 Thank you for signing the Contributor License Agreement!

@sunhao1256
Copy link
Contributor Author

fix checkstyle error

Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this to false breaks other basic functionality. Please add tests that show this working and not causing regressions

@sunhao1256 sunhao1256 closed this by deleting the head repository Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants