-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for aot compilation to be used when using in other repo as dependency #57
Conversation
@hakhan88 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@hakhan88 Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think this file should be changed. We don't want dist
and out-tsc
folder contents to be in the git repository. This is the built code it should only be in the npm registry not in the git repo.
@hakhan88 Thanks for the PR, it'd require a few adjustments. The built js code in
Please update your PR or I can simply pick the changes from your PR you'd want and apply them myself. Also I think you'd want us to release a new 0.8.10 version? Or you're ok to consume the current flo from master? |
Thanks for the review. Made the changes and pushed to the branch. Please let me know if naything further is required from my end. Thanks ! |
@hakhan88 LGTM merged. BTW, how do you consume Flo in your repo? As npm dependency on specific version? If you'd like to depend on Flo from master you can simply put |
thanks for the merge. I normally include it in the dependency for spring-flo on specific version. |
No description provided.