Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for aot compilation to be used when using in other repo as dependency #57

Merged
merged 10 commits into from
Jun 25, 2019

Conversation

hakhan88
Copy link
Contributor

No description provided.

@pivotal-issuemaster
Copy link

@hakhan88 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@hakhan88 Thank you for signing the Contributor License Agreement!

Copy link
Collaborator

@BoykoAlex BoykoAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this file should be changed. We don't want dist and out-tsc folder contents to be in the git repository. This is the built code it should only be in the npm registry not in the git repo.

@BoykoAlex
Copy link
Collaborator

BoykoAlex commented Jun 17, 2019

@hakhan88 Thanks for the PR, it'd require a few adjustments. The built js code in out-tsc and built angular module code under dist should not be in the git repo. Once we merge your PR we can make a 0.8.10 release for you to consume your fix.
I think the only changes you'd need in your PR would be:

  • src/lib/directives/resizer.ts
  • src/lib/properties/df.property.component.html

Please update your PR or I can simply pick the changes from your PR you'd want and apply them myself. Also I think you'd want us to release a new 0.8.10 version? Or you're ok to consume the current flo from master?

@hakhan88
Copy link
Contributor Author

Thanks for the review. Made the changes and pushed to the branch. Please let me know if naything further is required from my end. Thanks !

@BoykoAlex BoykoAlex merged commit 529a87f into spring-projects:master Jun 25, 2019
@BoykoAlex
Copy link
Collaborator

@hakhan88 LGTM merged. BTW, how do you consume Flo in your repo? As npm dependency on specific version? If you'd like to depend on Flo from master you can simply put "spring-flo": "https://github.com/spring-projects/spring-flo#master", in your package.json. When you npm install in your project with such dependency it'll build Flo during npm install...

@hakhan88
Copy link
Contributor Author

hakhan88 commented Jun 27, 2019

thanks for the merge. I normally include it in the dependency for spring-flo on specific version.
Because of #56, currently i cant use the way you suggested unless i change my dev environment OS to Mac !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants