Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get transfer status function #309

Merged
merged 27 commits into from
Nov 13, 2023
Merged

feat: get transfer status function #309

merged 27 commits into from
Nov 13, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Nov 3, 2023

Description

This PR implements utility function to get transfer status

Related Issue Or Context

Closes: #307

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

MakMuftic
MakMuftic reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general @wainola. One small nitpick.

packages/sdk/src/utils.ts Outdated Show resolved Hide resolved
@wainola
Copy link
Contributor Author

wainola commented Nov 3, 2023

@MakMuftic according to updates on the endpoint from indexer, domainId is going to be a query param, I guess we can add this parameter to the function as optional, lmk your thougths

MakMuftic
MakMuftic previously approved these changes Nov 3, 2023
View reviewed changes
@MakMuftic
Copy link
Contributor

@wainola just please fix lint error 🙏

@wainola wainola marked this pull request as ready for review November 6, 2023 13:48
@wainola
Copy link
Contributor Author

wainola commented Nov 7, 2023

@MakMuftic @FSM1 there are some linter errors that I need to fix and they are appearing for some reason. Could be related to the update of the ethers version

@wainola
Copy link
Contributor Author

wainola commented Nov 7, 2023

@MakMuftic @FSM1 there are some linter errors that I need to fix and they are appearing for some reason. Could be related to the update of the ethers version

Fixed

@wainola wainola requested a review from MakMuftic November 7, 2023 21:19
MakMuftic
MakMuftic previously approved these changes Nov 8, 2023
View reviewed changes
@wainola wainola requested a review from MakMuftic November 8, 2023 17:15
MakMuftic
MakMuftic previously approved these changes Nov 8, 2023
View reviewed changes
@wainola wainola requested review from FSM1 and MakMuftic November 13, 2023 16:37
@wainola wainola merged commit 7ac2946 into main Nov 13, 2023
3 checks passed
@wainola wainola deleted the feat/transfer-status branch November 13, 2023 17:08
@MakMuftic MakMuftic mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@FSM1 FSM1 FSM1 approved these changes

@mpetrun5 mpetrun5 Awaiting requested review from mpetrun5

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK should allow to retrieve transfer status
3 participants
@wainola @MakMuftic @FSM1