Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: throw an error when the source account has low balance #417

Merged
merged 27 commits into from
Aug 20, 2024

Conversation

Lykhoyda
Copy link
Contributor

Closes #338

@Lykhoyda Lykhoyda changed the title Lykhoyda/fix low balance fix: throw error when the source account has low balance Jul 30, 2024
@Lykhoyda Lykhoyda changed the title fix: throw error when the source account has low balance fix: throw an error when the source account has low balance Jul 30, 2024
@Lykhoyda Lykhoyda force-pushed the lykhoyda/fix_low_balance branch from b50f6b4 to 2bbda44 Compare July 30, 2024 10:05
@Lykhoyda Lykhoyda marked this pull request as ready for review July 30, 2024 10:51
@Lykhoyda Lykhoyda requested a review from saadahmsiddiqui July 31, 2024 09:11
packages/evm/src/fungible.ts Outdated Show resolved Hide resolved
@Lykhoyda Lykhoyda force-pushed the lykhoyda/fix_low_balance branch from d1e2457 to d17458e Compare August 10, 2024 13:24
@saadahmsiddiqui saadahmsiddiqui changed the title fix: throw an error when the source account has low balance fix!: throw an error when the source account has low balance Aug 19, 2024
@saadahmsiddiqui saadahmsiddiqui merged commit 201942b into main Aug 20, 2024
3 checks passed
@saadahmsiddiqui saadahmsiddiqui deleted the lykhoyda/fix_low_balance branch August 20, 2024 08:48
@saadahmsiddiqui saadahmsiddiqui restored the lykhoyda/fix_low_balance branch August 20, 2024 08:53
@saadahmsiddiqui saadahmsiddiqui deleted the lykhoyda/fix_low_balance branch August 20, 2024 15:00
@saadahmsiddiqui saadahmsiddiqui restored the lykhoyda/fix_low_balance branch August 20, 2024 15:08
@saadahmsiddiqui saadahmsiddiqui deleted the lykhoyda/fix_low_balance branch August 20, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using the SDK when trying to send a value higher than the balance is allowed
3 participants