-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(evm): Update SDK to Support New ERC20Handler with Optional Contract Call #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saadahmsiddiqui
changed the title
feat: Update SDK to Support New ERC20Handler with Optional Contract Call
feat(evm): Update SDK to Support New ERC20Handler with Optional Contract Call
Aug 28, 2024
Overall correct, though on the contracts side optionalGas if included must be accompanied by the optionalMessage, otherwise contract call would not happen. So allowing users to only include gas might create a false impression that it affects anything. |
Lykhoyda
previously approved these changes
Sep 9, 2024
wainola
previously approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two comments
…rc20-generic-handler
saadahmsiddiqui
dismissed stale reviews from wainola and Lykhoyda
via
September 9, 2024 12:12
4ec8bb7
Lykhoyda
approved these changes
Sep 9, 2024
wainola
approved these changes
Sep 9, 2024
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Sep 10, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](evm-v1.2.0...evm-v1.3.0) (2024-09-10) ### Features * **evm:** Update SDK to Support New ERC20Handler with Optional Contract Call ([#504](#504)) ([2cb56a2](2cb56a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation details
With the introduction of the new
ERC20Handler
, the SDK needs to be updated to handle the enhanced functionality that supports both ERC20 token transfers and optional contract calls in a single transaction. New ERC20Handler PRERC20Handler
by allowing it to handle additional data that encodes contract calls alongside ERC20 transfers.Closes: #493
Testing details
Acceptance Criteria
ERC20Handler
, allowing for both ERC20 transfers and optional contract calls within the same transaction.