Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evm): Expanding SDK to support Native transfer with optional con… #545

Merged
merged 10 commits into from
Sep 26, 2024
Prev Previous commit
Next Next commit
Merge branch 'main' of github.com:sygmaprotocol/sygma-sdk into saadjh…
…k/native-transfer-contract-call
saadahmsiddiqui committed Sep 19, 2024
commit 8c77b43ff8e7b5f3b6b6eaf8a474650bcb03be1c
6 changes: 4 additions & 2 deletions packages/evm/src/fungibleAssetTransfer.ts
Original file line number Diff line number Diff line change
@@ -141,7 +141,9 @@ class FungibleAssetTransfer extends AssetTransfer {
* associated with fungible transfer
* @returns {Promise<Array<TransactionRequest>>}
*/
public async getApprovalTransactions(): Promise<Array<TransactionRequest>> {
public async getApprovalTransactions(
overrides?: ethers.Overrides,
): Promise<Array<TransactionRequest>> {
if (this.isNativeTransfer()) {
return [];
wainola marked this conversation as resolved.
Show resolved Hide resolved
}
@@ -202,7 +204,7 @@ class FungibleAssetTransfer extends AssetTransfer {
return createTransactionRequest(transferTransaction);
}

public async getTransferTransaction(overrides?: PayableOverrides): Promise<TransactionRequest> {
public async getTransferTransaction(overrides?: ethers.Overrides): Promise<TransactionRequest> {
if (this.isNativeTransfer()) {
return await this.getNativeDepositTransaction(overrides);
}
You are viewing a condensed version of this merge commit. You can view the full changes here.