Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate deposit execution logic #14

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

nmlinaric
Copy link

Description

This PR separates the following logic:

  • deposit logic from Bridge contract to Router contract
  • execution logic from Bridge contract to Executor contract
  • Bridge now only has logic for configuring resource/routes,....

Related Issue Or Context

Closes: #2

How Has This Been Tested? Testing details.

  • unit tests
  • e2e tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/separate-deposit-execution branch from 0c7f45e to c962787 Compare November 22, 2023 15:08
@nmlinaric nmlinaric force-pushed the nmlinaric/separate-deposit-execution branch from c962787 to 1c84014 Compare November 22, 2023 16:01
src/contracts/handlers/FeeHandlerRouter.sol Outdated Show resolved Hide resolved
src/contracts/handlers/PermissionlessGenericHandler.sol Outdated Show resolved Hide resolved
src/contracts/Router.sol Outdated Show resolved Hide resolved
src/contracts/Router.sol Show resolved Hide resolved
src/contracts/Executor.sol Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from lastperson December 4, 2023 15:18
@tcar121293 tcar121293 self-requested a review December 12, 2023 08:57
@nmlinaric nmlinaric merged commit 4ea35ff into master Dec 12, 2023
3 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/separate-deposit-execution branch December 12, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate deposit and execution contracts
3 participants