Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor handlers so they return deposit data intead of handler response #15

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

mpetrun5
Copy link

Refactor handlers to they modify and return the deposit data and deprecate the handleResponse field.
Deposit data has to be modifed as the data submitted and stored on the source chain must be the same as the data sent to the executeProposals function on the destination for us to be able to do storage proofs.

Description

Related Issue Or Context

Closes: #3

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in Sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@mpetrun5 mpetrun5 changed the title Mpetrun5/refactor handlers feat: refactor handlers so they return deposit data intead of handler response Jan 10, 2024
@nmlinaric nmlinaric merged commit d402891 into master Jan 15, 2024
3 checks passed
@nmlinaric nmlinaric deleted the mpetrun5/refactor-handlers branch January 15, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor handlers
3 participants