forked from sprintertech/sygma-solidity
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rearrange core contracts addresses #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmlinaric
force-pushed
the
nmlinaric/reassing-addresses
branch
from
February 27, 2024 11:52
6f9ce42
to
6823a07
Compare
nmlinaric
force-pushed
the
nmlinaric/reassing-addresses
branch
from
March 13, 2024 13:18
6823a07
to
cbb411b
Compare
mpetrun5
requested changes
Mar 13, 2024
nmlinaric
force-pushed
the
nmlinaric/reassing-addresses
branch
3 times, most recently
from
March 15, 2024 08:56
114d7b5
to
e315cbf
Compare
nmlinaric
force-pushed
the
nmlinaric/reassing-addresses
branch
from
March 19, 2024 15:04
13f50c6
to
e2ed427
Compare
nmlinaric
force-pushed
the
nmlinaric/reassing-addresses
branch
from
March 19, 2024 15:07
e2ed427
to
276aca9
Compare
mpetrun5
changed the title
feat: rearrange core contracts addresses
feat!: rearrange core contracts addresses
Mar 25, 2024
lastperson
approved these changes
Mar 26, 2024
nmlinaric
changed the title
feat!: rearrange core contracts addresses
feat: rearrange core contracts addresses
Mar 26, 2024
lastperson
approved these changes
Mar 26, 2024
mpetrun5
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
Router
andExecutor
contract addresses to bridge and introduced newadminChangeRouterAndExecutor
function for changing the corresponding addresses.This way all handlers will always look at the same
Router
andExecutor
contracts and if required we can easily point them to new contracts if required (this reduces the number of contracts that need to be redeployed).Related Issue Or Context
Closes: #16
How Has This Been Tested? Testing details.
Types of changes
Checklist: