Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rearrange core contracts addresses #32

Merged
merged 10 commits into from
Mar 27, 2024

Conversation

nmlinaric
Copy link

Description

Moved Router and Executor contract addresses to bridge and introduced new adminChangeRouterAndExecutor function for changing the corresponding addresses.
This way all handlers will always look at the same Router and Executor contracts and if required we can easily point them to new contracts if required (this reduces the number of contracts that need to be redeployed).

Related Issue Or Context

Closes: #16

How Has This Been Tested? Testing details.

  • unit tests
  • e2e tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x} New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in Sygma-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@nmlinaric nmlinaric force-pushed the nmlinaric/reassing-addresses branch from 6f9ce42 to 6823a07 Compare February 27, 2024 11:52
@nmlinaric nmlinaric force-pushed the nmlinaric/reassing-addresses branch from 6823a07 to cbb411b Compare March 13, 2024 13:18
@nmlinaric nmlinaric marked this pull request as ready for review March 13, 2024 13:22
src/contracts/handlers/ERCHandlerHelpers.sol Outdated Show resolved Hide resolved
src/contracts/Bridge.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric force-pushed the nmlinaric/reassing-addresses branch 3 times, most recently from 114d7b5 to e315cbf Compare March 15, 2024 08:56
@nmlinaric nmlinaric requested a review from mpetrun5 March 15, 2024 08:57
@nmlinaric nmlinaric force-pushed the nmlinaric/reassing-addresses branch from 13f50c6 to e2ed427 Compare March 19, 2024 15:04
@nmlinaric
Copy link
Author

This should be merged after #43 & #44

@nmlinaric nmlinaric force-pushed the nmlinaric/reassing-addresses branch from e2ed427 to 276aca9 Compare March 19, 2024 15:07
@mpetrun5 mpetrun5 changed the title feat: rearrange core contracts addresses feat!: rearrange core contracts addresses Mar 25, 2024
@nmlinaric nmlinaric changed the title feat!: rearrange core contracts addresses feat: rearrange core contracts addresses Mar 26, 2024
@nmlinaric nmlinaric merged commit 11b9f67 into master Mar 27, 2024
3 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/reassing-addresses branch March 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make handler be reassignable by admin
3 participants